[RNMobile] Add outline around selected Social Link block #53377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekblank
added
[Type] Enhancement
|
Size Change: 0 B Total Size: 1.44 MB ℹ️ View Unchanged
|
derekblank
commented
Aug 7, 2023
| @@ -119,6 +119,7 @@ const SocialLinkEdit = ( { | |||
| toValue: 1, | |||
| duration: ANIMATION_DURATION, | |||
| easing: Easing.circle, | |||
| useNativeDriver: false, | |||
There was a problem hiding this comment.
When using Animated, it is required to specify the value of useNativeDriver. This change suppresses the LogBox warning:
Animated: useNativeDriver was not specified. This is a required option and must be explicitly set to true or false.
geriux
approved these changes
Aug 8, 2023
derekblank
added
the
Mobile App - Automation
4 tasks
|
👋 Hey @derekblank, while testing in WP 23.1-rc-2 beta, I noticed the outline isn't shown when new social icons are added. The outlines show for the default icons but not for the ones added. The screen recording shows me adding and selecting the Facebook icon, but no outline is shown. Screen_Recording_20230828_171035_WordPress.mov |
|
@guarani Good catch! I'll check this out. |
|
Thanks @derekblank! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds outline around the selected Social Link icon on mobile.
Why?
Block Outlines were updated in #52702, with many outlines being removed. Design feedback indicated that a displaying an outline around the selected Social Link icon would help users to note which icon is selected.
How?
Updates the BlockOutline component to include the Social Link block as a block to be outlined.
Testing Instructions
Screenshots or screencast
Social.Links.mov