[RNMobile] Add block outline to all Social Link blocks when selected #54011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekblank
added
[Type] Bug
2 tasks
|
Size Change: 0 B Total Size: 1.51 MB ℹ️ View Unchanged
|
dcalhoun
approved these changes
Aug 29, 2023
This was referenced Aug 30, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates the native block outline component to add outlines to all Social Link blocks when selected.
Why?
Not all Social Link blocks were receiving the outline when selected. Blocks added via the [+] icon block inserter did not receive the outline. This was due to the block name itself, and how it was being matched as a string in the native Block Outline component. The initial four Social Link blocks (WordPress, Facebook, Twitter, Instagram) all have an initial HTML value of
core/social-link. When new Social Link blocks are added from the inserter, they use the specific name of the block, e.g.:core/social-link-amazon.How?
This PR updates the Block Outline pattern matching to outline any block whose name contains
core/social-link(rather than the previous other way around where the block name had to matchcore/social-linkas a string). This PR also restores some of the previous separation-of-concerns by separating Social blocks from Text blocks in the Block Outline component, and providing Social Link blocks their ownconstfor matching.Testing Instructions
Screenshots or screencast
263835671-11406ff8-c2c0-489e-99ac-a027696123d0.mov
Social.Icons.test.mov