Code Quality: Remove gutenberg_initialize_editor
#53527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/experimental/editor-settings.php |
ockham
changed the title
gutenberg_initialize_editorgutenberg_initialize_editor
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Remove the
gutenberg_initialize_editorfunction, defined inlib/experimental/editor-settings.php.Why?
I came across this function the other day. A quick
greprevealed that it doesn't seem to be called anywhere.git bisectrevealed that the last known use of that function was inlib/experimental/navigation-page.php, which was removed in #47055, alongside a lot of other code. It was probably by oversight thatgutenberg_initialize_editorwas left behind.How?
Delete
Testing Instructions
Look for any invocations of
gutenberg_initialize_editor, or maybe justinitialize_editorif you're paranoid (like myself) that maybe we do some obscure prefix mangling somewhere in the build process.Also, give the editor some smoke testing (both Post Editor and Site Editor).