Toggle Distraction free mode mode based on compatibility #54030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
ntsekouras
requested review from
draganescu,
Mamaduka,
youknowriad,
richtabor and
t-hamano
ntsekouras
commented
Aug 29, 2023
| @@ -295,6 +286,9 @@ function useEditUICommands() { | |||
| label: __( 'Toggle top toolbar' ), | |||
| callback: ( { close } ) => { | |||
| toggle( 'core/edit-site', 'fixedToolbar' ); | |||
| if ( isDistractionFree ) { | |||
There was a problem hiding this comment.
For now this is the only one left from the issue, because we call directly the preferences store action.
ntsekouras
commented
Aug 29, 2023
|
Size Change: -116 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
ntsekouras
force-pushed
the
fix/dfm-mode-toggle-conditionally
branch
from
ac1e429 to
547c8c9
Compare
ntsekouras
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
Flaky tests detected in 547c8c998aa6ebe99b4b4ef4fbb4a94ab30a0888. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6014986504
|
draganescu
reviewed
Aug 30, 2023
draganescu
approved these changes
Aug 30, 2023
ntsekouras
force-pushed
the
fix/dfm-mode-toggle-conditionally
branch
from
547c8c9 to
b21ee24
Compare
17 tasks
t-hamano
reviewed
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #53993
Distraction free mode in combination with some commands/shortcuts etc may cause layout corruption. This is mostly due to the fact that DFM expect there are no sidebars opened. Currently in trunk we handled some of these cases by manually closing those sidebars and toggling some settings like the top toolbar. In order to avoid having to do this every time we need to, I've moved this logic in some of the actions.
This PR handles most of the cases in
site editoronly and a very similar PR will be needed forpost editortoo.Testing Instructions for site editor
Test when we enable DFM either through shortcut, command or in header options, any sidebar is closed.
Whenever we toggle the DFM observe that a snackbar appears with related information.
Test the following commands when DFM is on and observe that the sidebars are closed: