[Edit Post]: Toggle Distraction free mode mode based on compatibility #54073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
ntsekouras
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
ntsekouras
commented
Aug 30, 2023
| @@ -131,6 +137,9 @@ export default function useCommonCommands() { | |||
| label: __( 'Toggle top toolbar' ), | |||
| callback: ( { close } ) => { | |||
| toggle( 'core/edit-post', 'fixedToolbar' ); | |||
| if ( isDistractionFree ) { | |||
There was a problem hiding this comment.
For now this is the only one left from the issue, because we call directly the preferences store action.
|
Size Change: +95 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in fa8e730. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6028066587
|
draganescu
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #53993
Distraction free mode in combination with some commands/shortcuts etc may cause layout corruption. This is mostly due to the fact that DFM expect there are no sidebars opened. Currently in trunk we handled some of these cases by manually closing those sidebars and toggling some settings like the top toolbar. In order to avoid having to do this every time we need to, I've moved this logic in some of the actions.
This is very similar PR with #54030, that handled most cases in site editor.
Testing Instructions for post editor
Test when we enable DFM either through shortcut or command, that any sidebar is closed.
Whenever we toggle the DFM observe that a snackbar appears with related information.
Test the following commands when DFM is on and observe that the sidebars are closed: