Allow using CSS level 4 viewport-relative units #54415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aristath
changed the title
|
Size Change: +1.09 kB (0%) Total Size: 1.65 MB
ℹ️ View Unchanged
|
aristath
force-pushed
the
support-viewport-relative-css-units
branch
from
38e563f to
c37bdad
Compare
aristath
requested review from
ajitbohra,
ellatrix and
ajlende
as code owners
aristath
changed the title
ajlende
reviewed
Sep 14, 2023
aristath
force-pushed
the
support-viewport-relative-css-units
branch
from
c37bdad to
71c990e
Compare
aristath
force-pushed
the
support-viewport-relative-css-units
branch
from
febc88b to
fe741ae
Compare
|
Hey folks, when making changes to |
|
My apologies @ciampo, I missed that. Do you want me to do a quick follow-up PR? |
|
That would be great, thank you! Feel free to ping me for the review :) |
aristath
added a commit
that referenced
this pull request
Oct 10, 2023
|
Thanks! Added a PR in #55201 👍 |
aristath
added a commit
that referenced
this pull request
Oct 11, 2023
justintadlock
added
the
[Feature] Design Tools
9 tasks
This was referenced Dec 8, 2024
|
Seemingly related to this PR above, Chiming in that this opt-in of new units works correct for padding, block gap, min height, BUT is not showing up in the dropdown for Dimensions > Height > Fixed (a field that only appears for certain nested group/stack/row blocks for example) Started an issue here to discuss and shared a screenshot etc: #67750 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds support for viewport-relative, CSS level-4 units.
These units are not exposed anywhere by default, but if a user enables them via
theme.json, they should be available.All these units have good browser support (see https://caniuse.com/viewport-unit-variants) and will allow designers to build more versatile interfaces.
Fixes #52441
Why?
Because we should not explicitly forbid the use of CSS units - which is what happens if they are not defined in our lists of available CSS units.
How?
Testing Instructions
theme.jsonfile. Insettings.spacing.unitswe have an array of units that the theme supports. In that array, add some of the units defined in this PR (like for examplesvmin,svmax)Testing Instructions for Keyboard
Nothing specific for keyboard users. This change allows selecting more units, and does not change the existing selectors so nothing changes in the UI/UX.
Screenshots or screencast