Fix duotone not showing in site editor style block level styles #55361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajlende
added
[Type] Bug
|
Size Change: -36 B (0%) Total Size: 1.66 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in cdf41e5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6513288292
|
draganescu
reviewed
Oct 17, 2023
This reverts commit 5550a60a872b1d9609fd5294fe58cf5f0163e187.
This reverts commit 0da2522c34c8388c163f2c3a8c1d424b4d254916.
ajlende
force-pushed
the
fix/duotone-filters-panel-visibility
branch
from
cdf41e5 to
b9bdc6e
Compare
Hmmm. My TT4 was out of date, so I thought that might be it, but it's still working for me on latest trunk. I also rebased with trunk on this PR, reinstalled node_modules in case those were out of date, but again it's still working for me. |
jeryj
approved these changes
Oct 19, 2023
MaggieCabrera
added
the
Backport to WP Minor Release
mikachan
pushed a commit
that referenced
this pull request
Nov 9, 2023
|
I just cherry-picked this PR to the 6.4-next-point-release branch to get it included in the next release: f195323 |
mikachan
removed
the
Backport to WP Minor Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes an issue where the block-level duotone controls weren't available in the site editor styles controls.
Why?
Bug fix
How?
Testing Instructions
settings.color.defaultDuotoneenabled and/orsettings.color.duotoneas a non-empty array.settings.color.customDuotoneand neither of the other settings should not show the filters panel at all.Testing Instructions for Keyboard
N/A
Screenshots or screencast
Screenshots show TT4 with these relevant settings.
settings.color.customDuotoneistrueby default; however the custom color picker controls aren't shown because custom colors aren't supported in this context yet (see #50332).Before
After