-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duotone not showing in site editor style block level styles #55361
Conversation
Size Change: -36 B (0%) Total Size: 1.66 MB
ℹ️ View Unchanged
|
Flaky tests detected in cdf41e5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6513288292
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code makes sense to me but testing this with TT4 I still don't see the duotone filter when selecting styles -> blocks -> image.
This reverts commit 5550a60a872b1d9609fd5294fe58cf5f0163e187.
This reverts commit 0da2522c34c8388c163f2c3a8c1d424b4d254916.
cdf41e5
to
b9bdc6e
Compare
Hmmm. My TT4 was out of date, so I thought that might be it, but it's still working for me on latest trunk. I also rebased with trunk on this PR, reinstalled node_modules in case those were out of date, but again it's still working for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Tested with TT3 and TT4 and confirmed with both duotone on and off from theme.json.
I just cherry-picked this PR to the 6.4-next-point-release branch to get it included in the next release: f195323 |
What?
Fixes an issue where the block-level duotone controls weren't available in the site editor styles controls.
Why?
Bug fix
How?
Testing Instructions
settings.color.defaultDuotone
enabled and/orsettings.color.duotone
as a non-empty array.settings.color.customDuotone
and neither of the other settings should not show the filters panel at all.Testing Instructions for Keyboard
N/A
Screenshots or screencast
Screenshots show TT4 with these relevant settings.
settings.color.customDuotone
istrue
by default; however the custom color picker controls aren't shown because custom colors aren't supported in this context yet (see #50332).Before
After