DataViews: remove reset values from filters #55839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Type] Code Quality
This was referenced Nov 3, 2023
|
Size Change: -39 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
oandregal
commented
Nov 3, 2023
| @@ -37,6 +37,10 @@ const defaultConfigPerViewType = { | |||
| }, | |||
| }; | |||
|
|
|||
| // DEFAULT_STATUSES is intentionally sorted. Items do not have spaces in between them. | |||
| // The reason for that is to match the default statuses coming from the endpoint (entity request). | |||
| export const DEFAULT_STATUSES = 'draft,future,pending,private,publish'; // All statuses but 'trash'. | |||
There was a problem hiding this comment.
By changing this string (e.g.: remove one of the items), two requests will be dispatched to the pages endpoint (this is how to test that this is working as expected). The same will happen if the site provides custom statuses.
oandregal
commented
Nov 3, 2023
| resetValue: defaultStatuses, | ||
| }, | ||
| ], | ||
| filters: [ 'enumeration' ], |
There was a problem hiding this comment.
After these changes to the filters API as well as others that are in-flight at the moment, my next step would be to clean up this a bit. It'll be now slimmer (there is no longer a need for filters to be objects, for example).
|
Flaky tests detected in 8c4a993. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6744122906
|
youknowriad
approved these changes
Nov 3, 2023
|
This introduced a bug that #55856 fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #55083
What?
Updates the filters for they to use the same default value (empty string). It's the consumer's responsibility to handle the how that default value is converted to a REST API call.
Why?
This has a double effect:
How?
It's the consumer responsibility to handle the situation in which no value is selected for the filter. In some cases, this would mean to use the REST API defaults (
authorfilter), in some other cases it'd mean to provide different defaults (statusfilter).Testing Instructions