DataViews: fix status filter upon switching the default views from the sidebar #55856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Type] Bug
|
Size Change: +1.35 kB (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in cd28877. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6769588517
|
youknowriad
approved these changes
Nov 6, 2023
ntsekouras
reviewed
Nov 6, 2023
| ( f ) => f.field === filter.id && f.operator === OPERATOR_IN | ||
| )?.value; | ||
|
|
||
| if ( ! activeValue ) { |
There was a problem hiding this comment.
Not affecting us right now, but this would make zero value impossible to set.
There was a problem hiding this comment.
you're right maybe we can make a small change here and drop the ?.value; from the line above and only do .value in the rendering of the component.
There was a problem hiding this comment.
Nice one, thanks! Pushed a fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #55083
Follow-up to #55839
What?
Fixes an issue by which the "All" view in the sidebar doesn't update the status filter.
This is how it should behave:
Gravacao.do.ecra.2023-11-03.as.17.02.36.mov
Testing Instructions
At all points, the status filter should reflect the selected view.