Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataViews: fix status filter upon switching the default views from the sidebar #55856

Merged
merged 2 commits into from
Nov 6, 2023
Merged

DataViews: fix status filter upon switching the default views from the sidebar #55856

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e41a1cc
Fix default filter case
oandregal Nov 3, 2023
cd28877
Properly validate whether value exists
oandregal Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/edit-site/src/components/dataviews/in-filter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,13 @@ import {
const OPERATOR_IN = 'in';

export default ( { filter, view, onChangeView } ) => {
const activeValue = view.filters.find(
let activeValue = view.filters.find(
( f ) => f.field === filter.id && f.operator === OPERATOR_IN
)?.value;

if ( ! activeValue ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not affecting us right now, but this would make zero value impossible to set.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right maybe we can make a small change here and drop the ?.value; from the line above and only do .value in the rendering of the component.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks! Pushed a fix.

activeValue = '';
}
return (
<SelectControl
value={ activeValue }
Expand Down
Loading