Font Library: create fonts dir if a font face needs to use the file system

[matiasbenedetto]

What?

Font Library: create fonts dir if a font face needs to use the filesystem

Why?

Because if the fonts directory is not created the writing of the fonts files can fail on certain servers.

How?

create fonts dir if a font face needs to use the filesystem

Testing Instructions

• Navigate to the font library.
• Try to install a font from Google Fonts collection.
• Check that is working as expected.

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ lib/experimental/fonts/font-library/class-wp-font-family.php

[pbking]

I think perhaps this change handles that situation, which has already been merged but might not have been in the build that was being tested.

[matiasbenedetto]

I think perhaps https://github.com/WordPress/gutenberg/pull/55893handles that situation, which has already been merged but might not have been in the build that was being tested.

@pbking thanks for pointing that out. Yep, that change should fix the problem when you try to add fonts using the API but I'm not sure that a REST API controller should be in charge of creating a directory but it doesn't hurt. Apart from that, I think the PHP class in charge of writing the font assets to the filesystem should be able to write the containing folder so I think this PR is still needed.

[mikachan]

This tests well for me! I can successfully install a font from Google Fonts with this PR ✅

I've left a minor comment with a suggested wording change.