Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font Library: create fonts dir if a font face needs to use the file system #56120

Merged
merged 4 commits into from
Nov 15, 2023
Merged

Font Library: create fonts dir if a font face needs to use the file system #56120

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f348633
create fonts dir if a font face need to use the filesystem
matiasbenedetto Nov 14, 2023
df3df3f
php format
matiasbenedetto Nov 14, 2023
9ccfe47
avoid error supress
matiasbenedetto Nov 14, 2023
707650c
Update lib/experimental/fonts/font-library/class-wp-font-family.php
matiasbenedetto Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/experimental/fonts/font-library/class-wp-font-family.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,11 @@ private function download_or_move_font_faces( $files ) {
continue;
}

// If the font face requires the use of the filesystem, create the fonts dir if it doesn't exist.
if ( ! empty( $font_face['downloadFromUrl'] ) && ! empty( $font_face['uploadedFile'] ) ) {
wp_mkdir_p( WP_Font_Library::get_fonts_dir() );
}

// If installing google fonts, download the font face assets.
if ( ! empty( $font_face['downloadFromUrl'] ) ) {
$new_font_face = $this->download_font_face_assets( $new_font_face );
Expand Down
Loading