PostFormat suggestion: fix double parsing #56255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
commented
Nov 17, 2023
|
Size Change: -13 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 19bb9fe. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6905482309
|
ellatrix
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
ellatrix
commented
Nov 17, 2023
ellatrix
commented
Nov 17, 2023
| const blocks = this.props.blocks; | ||
| const blocks = | ||
| this.props.getEditedPostAttribute( 'blocks' ) || | ||
| parse( this.props.getEditedPostContent() ); |
There was a problem hiding this comment.
There's something terribly wrong here on the native side, but that's out of the scope of this PR. The blocks in the block editor store should be available when the editor is ready, yet they aren't (causing some test failures). I've just restore the logic from getEditorBlocks, though obviously it's going to parse the content here.
Mamaduka
reviewed
Nov 18, 2023
| supportedFormats: themeSupports.formats, | ||
| }; | ||
| }, [] ); | ||
| const suggestedFormat = getSuggestedPostFormat( blocks ); |
There was a problem hiding this comment.
It might be more performant to derive value inside the mapSelect, so we don't re-render the component on every block change.
There was a problem hiding this comment.
Right, will have to revert to using the selector
There was a problem hiding this comment.
Here's my alternative PR #56679.
Mamaduka
reviewed
Nov 18, 2023
Comment on lines
+50
to
+53
| const suggestion = getSuggestion( | ||
| supportedFormats ?? [], | ||
| getSuggestedPostFormat( blocks ) | ||
| ); |
Mamaduka
reviewed
Nov 18, 2023
| return null; | ||
| } | ||
| export function getSuggestedPostFormat() { | ||
| return null; |
There was a problem hiding this comment.
We should properly deprecate this selector.
|
This is cool. Thanks for noticing this duplication. |
|
@Mamaduka You fixed this one entirely in the end right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
#52417 introduced a performance regression when the sidebar is open: the post is now parsed twice on load.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast