Editor: Avoid double parsing content in 'getSuggestedPostFormat' selelector #56679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Performance
Mamaduka
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
Mamaduka
requested review from
mcsf,
youknowriad and
ellatrix
and removed request for
juanmaguitar,
ajitbohra,
ryanwelcher,
ndiego and
fabiankaegy
|
Size Change: +3 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Nov 30, 2023
|
Thanks, Riad! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a partial alternative to #56255, as it doesn't include optimizations for the "maybe upload media" panel.
The
getSuggestedPostFormatnow grabs blocks via theblock editorstore, instead ofgetEditorBlocks.Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast