Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2e tests: merge Puppeteer into single job, split Playwright further #56363

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented Nov 21, 2023

What?

The Playwright tests have been taking longer and longer (~20 mins), so it'd be good to add more jobs. Since there's still Puppeteer tests remaining, and other tests being added, this will only get worse over time, so I doubled the jobs.

Additionally, since the number of Puppeteer tests is greatly reduced, these test take barely any time anymore, so we can merge them all into one job I think. Again, over time, no tests should be left here.

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@ellatrix ellatrix added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Nov 21, 2023
@Mamaduka
Copy link
Member

I think we should also update the repo settings for required jobs. cc @talldan

Copy link

Flaky tests detected in 3160965.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6945548945
📝 Reported issues:

@talldan
Copy link
Contributor

talldan commented Nov 22, 2023

I think we should also update the repo settings for required jobs. cc @talldan

Unfortunately that can only be done after the PR has merged and the new jobs have successfully completed once on trunk.

At least that's how it was the last few times.

@talldan
Copy link
Contributor

talldan commented Nov 24, 2023

I'll go ahead and merge this, then update the required checks 👍

@talldan talldan merged commit c6e3890 into trunk Nov 24, 2023
51 checks passed
@talldan talldan deleted the try/e2e-split-merge branch November 24, 2023 02:40
@github-actions github-actions bot added this to the Gutenberg 17.2 milestone Nov 24, 2023
@ellatrix
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants