Global styles revisions: remove PHP unit tests that are running in Core #56492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Type] Code Quality
ramonjd
commented
Nov 24, 2023
| * | ||
| * @covers Gutenberg_REST_Global_Styles_Revisions_Controller_6_4::get_items | ||
| */ | ||
| public function test_get_items() { |
There was a problem hiding this comment.
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ phpunit/class-gutenberg-rest-global-styles-revisions-controller-test.php |
ramonjd
commented
Nov 24, 2023
| */ | ||
| public function test_get_item_schema() { |
There was a problem hiding this comment.
Keeping tests that cover latest compat changes (6.5)
tellthemachines
force-pushed
the
update/global-styles-revision-controller-prune-tests
branch
from
1e54d59
to
ce2e338
Compare
tellthemachines
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Changes LGTM and remaining tests are passing!
I just rebased the branch to get the changes from #56363 so CI will start running again.
ramonjd
deleted the
update/global-styles-revision-controller-prune-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Pruning unit tests that have already been migrated to core.
Keeping tests that cover latest compat changes (6.5)
Why?
The deleted tests do not test any plugin-specific functionality. They test functionality that already exists in Core.
How?
Testing Instructions
npm run test:unit:php:base -- --filter Gutenberg_REST_Global_Styles_Revisions_Controller_Test