Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Spinner - add Storybook link #56818

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Conversation

bph
Copy link
Contributor

@bph bph commented Dec 6, 2023

What?

Documentation page for Search Control is linked in Data Layer Course on Learn.WordPress and needs a link to the Storybook space.

Why?

It would help a learner to know about Storybook space for more visual exploration of components.

How?

added the link to the readme.md for the component

Testing Instructions

Use the View file feature under Files changed

@bph bph requested a review from ajitbohra as a code owner December 6, 2023 11:39
@bph bph self-assigned this Dec 6, 2023
@bph bph added [Type] Developer Documentation Documentation for developers [Package] Components /packages/components labels Dec 6, 2023
Copy link

github-actions bot commented Dec 6, 2023

Flaky tests detected in 7536eeb.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7125302836
📝 Reported issues:

Copy link
Contributor

@apeatling apeatling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@apeatling apeatling merged commit 25cd246 into trunk Dec 8, 2023
51 of 52 checks passed
@apeatling apeatling deleted the docs/add-storybook-spinner branch December 8, 2023 20:41
@github-actions github-actions bot added this to the Gutenberg 17.3 milestone Dec 8, 2023
apeatling added a commit that referenced this pull request Dec 8, 2023
apeatling added a commit that referenced this pull request Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants