-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Add storybook link for spinner component #56953
Conversation
Flaky tests detected in 1a171d8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7171734615
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice attention to detail! This updates the Spinner docs page with the correct link to Storybook, which I see is referenced from the https://learn.wordpress.org/lesson/retrieving-wordpress-data-records/ tutorial page. That page also has a link to the SearchControl page which appears to already include the link to the appropriate Storybook entry, so looks like this PR finishes things off 👍
LGTM! ✨
Oh, I see the |
@andrewserong I will follow up on that now. I merged at the same time you posted that comment! |
Apologies! I only saw the red cross against that Github action after I hit submit 😄 |
Changelog updating PR here #56960 |
Thank you @apeatling for taking my idea over the finish line by fixing my mistake |
What?
Follow up to #56818 that was reverted. This places the added storybook link in the spinner component doc.
Why?
The previous PR placed it in the search component docs by mistake.
How?
Adding the link.
Testing Instructions
Check the link to storybook works.