Block editor: use context for useBlockEditingMode #57950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +25 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Jan 18, 2024
| const { clientId = '' } = useBlockEditContext(); | ||
| const blockEditingMode = useSelect( | ||
| ( select ) => | ||
| select( blockEditorStore ).getBlockEditingMode( clientId ), |
There was a problem hiding this comment.
Where is this value filled in the context now (I failed to follow your changes). Where is this call being made basically.
There was a problem hiding this comment.
We already make it:
ellatrix
force-pushed
the
try/block-editing-mode-use-context
branch
from
1d11555
to
fbab0eb
Compare
youknowriad
approved these changes
Jan 18, 2024
ellatrix
added a commit
that referenced
this pull request
Jan 18, 2024
ellatrix
added a commit
that referenced
this pull request
Jan 18, 2024
ellatrix
added a commit
that referenced
this pull request
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Alternative to #57941.
Removes a block-editor store subscription from all paragraphs and headings, potentially also other blocks.
Why?
Fixes performance regression from #57906.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast