Block editor: fix performance regression after #57950 #57971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
force-pushed
the
fix/perf-regression-private-contex
branch
from
761ad1e
to
9306415
Compare
|
Size Change: +43 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Jan 18, 2024
ellatrix
force-pushed
the
fix/perf-regression-private-contex
branch
from
39778cb
to
c7a123d
Compare
It's fine depending on the situation, like if a component will anyway re-render. But it's marked private for a reason :p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I made a big performance regression in #57950. Probably because of using the private context, which changes on every render, which will cause even nested "pure" components to re-render. We should use the blockEdit context instead, which is memoized.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast