Block Bindings: lock editing of blocks by default #58787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantosGuillamot
added
[Type] Enhancement
SantosGuillamot
requested review from
ellatrix,
fluiddot,
dcalhoun,
artemiomorales,
michalczaplinski and
ajitbohra
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +75 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
42 tasks
|
|
||
| export default { | ||
| name: 'core/pattern-overrides', | ||
| label: __( 'Pattern Overrides' ), |
There was a problem hiding this comment.
Shouldn't we use the _x() like we do on the PHP side (example). If yes, that would also apply to the post-meta source.
There was a problem hiding this comment.
They should be exactly the same as on the server. Good catch 👍
There was a problem hiding this comment.
Good catch 🙂 Changed in this commit.
There was a problem hiding this comment.
Would it not be simpler to add a default true value to the reducer on this line instead of adding the !== false checks in multiple places? I think it would also make it easier to update the default value in the future.
Other than that, I think it totally makes sense! 👍
|
Basically I was suggesting this: diff --git a/packages/block-editor/src/store/reducer.js b/packages/block-editor/src/store/reducer.js
index c465e39021..b625c5989d 100644
--- a/packages/block-editor/src/store/reducer.js
+++ b/packages/block-editor/src/store/reducer.js
@@ -2051,7 +2051,7 @@ function blockBindingsSources( state = {}, action ) {
[ action.sourceName ]: {
label: action.sourceLabel,
useSource: action.useSource,
- lockAttributesEditing: action.lockAttributesEditing,
+ lockAttributesEditing: action.lockAttributesEditing ?? true,
},
};
}It would default to |
SantosGuillamot
force-pushed
the
update/lock-editing-by-default-in-block-bindings
branch
from
eef62cb
to
79a42c5
Compare
|
Totally makes sense! Thanks for pointing that out 🙂 I made the changes in this commit. Let me know if that's what you had in mind. |
gziolo
reviewed
Feb 9, 2024
| /** | ||
| * Internal dependencies | ||
| */ | ||
| import { store as editorStore } from '../store'; | ||
|
|
||
| export default { | ||
| name: 'core/post-meta', | ||
| label: __( 'Post Meta' ), | ||
| label: _x( 'Post Meta' ), |
There was a problem hiding this comment.
We should mirror: https://github.com/WordPress/wordpress-develop/blob/acad00ecabcf44a6c4e552c4fd518ee708fd131f/src/wp-includes/block-bindings/post-meta.php#L52
_x( 'Post Meta', 'block bindings source' ),There was a problem hiding this comment.
You're right! Done in this commit.
SantosGuillamot
added
the
Backport to WP 6.7 Beta/RC
michalczaplinski
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
I made the changes in this commit. Let me know if that's what you had in mind.
Yup, perfect 🙂
All in all LGTM! 👍
SantosGuillamot
deleted the
update/lock-editing-by-default-in-block-bindings
branch
aristath
added a commit
that referenced
this pull request
Feb 13, 2024
* trunk: (273 commits) Remove preffered style variations legacy support (#58930) Style theme variations: add property extraction and merge utils (#58803) Migrate `change-detection` to Playwright (#58767) Update Changelog for 17.6.6 Docs: Clarify the status of the wp-block-styles theme support, and its intent (#58915) Use `data_wp_context` helper in core blocks and remove `data-wp-interactive` object (#58943) Try double enter for details block. (#58903) Template revisions API: move from experimental to compat/6.4 (#58920) Editor: Remove inline toolbar preference (#58945) Clean up link control CSS. (#58934) Font Library: Show error message when no fonts found to install (#58914) Block Bindings: lock editing of blocks by default (#58787) Editor: Remove the 'all' rendering mode (#58935) Pagination Numbers: Add `data-wp-key` to pagination numbers if enhanced pagination is enabled (#58189) Close link preview if collapsed selection when creating link (#58896) Fix incorrect useAnchor positioning when switching from virtual to rich text elements (#58900) Upgrade Floating UI packages, fix nested iframe positioning bug (#58932) Site editor: fix start patterns store selector (#58813) Revert "Rich text: pad multiple spaces through en/em replacement (#56341)" (#58792) Documentation: Clarify the performance reference commit and how to pick it (#58927) ...
youknowriad
pushed a commit
that referenced
this pull request
Feb 13, 2024
* Lock editing by default when bindings exist * Use default in post meta source * Set `lockEditing` to false in pattern overrides * Move default value to reducer * Use `_x` for sources translations * Add context to translations
|
I just cherry-picked this PR to the backports/beta1 branch to get it included in the next release: 72a22e5 |
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Feb 13, 2024
* Lock editing by default when bindings exist * Use default in post meta source * Set `lockEditing` to false in pattern overrides * Move default value to reducer * Use `_x` for sources translations * Add context to translations
youknowriad
pushed a commit
that referenced
this pull request
Feb 13, 2024
* Lock editing by default when bindings exist * Use default in post meta source * Set `lockEditing` to false in pattern overrides * Move default value to reducer * Use `_x` for sources translations * Add context to translations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This pull request locks the editing of the rich text and the appropriate controls of button and image blocks by default when a binding exists.
Why?
Right now, if sources want to lock the editing when an attribute is bound to it, they have to specify that explicitly. However, the editor APIs are still private, so there is no way to do that for external sources. I believe locking it by default would cover most of the use cases.
Once we add support to editing the custom fields, we can change the default.
How?
I changed the locking conditionals to only unlock the editing when it is set to false and I added that to the pattern overrides source, because they don't need that.
Testing Instructions
Tests should cover the use cases.
For manual testing:
Ensure that the existing bindings keep working as expected:
In a page
Test paragraph
Test heading
Repeat the paragraph test but using a heading.
Test button
Test image
In a template
Go to a page template, for example, and repeat the process. In this case, the blocks can't show the value of the custom fields because it depends on each page. They should show a placeholder instead.
Test pattern syncing overrides