Upgrade Floating UI packages, fix nested iframe positioning bug #58932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
tyxla
approved these changes
Feb 12, 2024
|
Size Change: +141 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 6ac2da3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7871558762
|
|
Hard to build muscle memory but friendly reminder about this one for the next PRs #58932 (comment) :) |
|
🤦 |
|
It works on my local built storyboard! But how will the WordPress Playground be updated with the new library version? |
It's like any other fix: a new Gutenberg version needs to be released, or the patch backported to Core. I don't know where exactly does a given Playground instance get its Core and Gutenberg versions. |
youknowriad
added
the
Backport to WP 6.7 Beta/RC
aristath
added a commit
that referenced
this pull request
Feb 13, 2024
* trunk: (273 commits) Remove preffered style variations legacy support (#58930) Style theme variations: add property extraction and merge utils (#58803) Migrate `change-detection` to Playwright (#58767) Update Changelog for 17.6.6 Docs: Clarify the status of the wp-block-styles theme support, and its intent (#58915) Use `data_wp_context` helper in core blocks and remove `data-wp-interactive` object (#58943) Try double enter for details block. (#58903) Template revisions API: move from experimental to compat/6.4 (#58920) Editor: Remove inline toolbar preference (#58945) Clean up link control CSS. (#58934) Font Library: Show error message when no fonts found to install (#58914) Block Bindings: lock editing of blocks by default (#58787) Editor: Remove the 'all' rendering mode (#58935) Pagination Numbers: Add `data-wp-key` to pagination numbers if enhanced pagination is enabled (#58189) Close link preview if collapsed selection when creating link (#58896) Fix incorrect useAnchor positioning when switching from virtual to rich text elements (#58900) Upgrade Floating UI packages, fix nested iframe positioning bug (#58932) Site editor: fix start patterns store selector (#58813) Revert "Rich text: pad multiple spaces through en/em replacement (#56341)" (#58792) Documentation: Clarify the performance reference commit and how to pick it (#58927) ...
youknowriad
pushed a commit
that referenced
this pull request
Feb 13, 2024
* Upgrade Floating UI packages, fix nested iframe positioning bug * Update components changelog
|
I just cherry-picked this PR to the backports/beta1 branch to get it included in the next release |
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Feb 13, 2024
* Upgrade Floating UI packages, fix nested iframe positioning bug * Update components changelog
youknowriad
pushed a commit
that referenced
this pull request
Feb 13, 2024
* Upgrade Floating UI packages, fix nested iframe positioning bug * Update components changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades Floating UI packages to their latest version. The latest version of
@floating-ui/domincludes floating-ui/floating-ui#2785 which in turn fixes #58756.This also fixes the positioning bug we've been seeing in Storybook for some time. Now the positioning in Storybook is 100% right!