Revert removal of Nav fallback auto embed #59220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
requested review from
Mamaduka and
youknowriad
and removed request for
nerrad
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
getdave
added
[Block] Navigation
|
Size Change: +2.56 kB (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Feb 20, 2024
| dispatch.receiveNavigationFallbackId( fallback?.id ); | ||
|
|
||
| if ( record ) { |
There was a problem hiding this comment.
I know this is specific to the previous regression, but should we check for content.raw existence in the record before seeding it to the cache?
getdave
added
the
Backport to WP 6.7 Beta/RC
|
I'm going to get this backported to 6.5 because the original code has been in previous versions of WP and this PR is simply restoring existing code. |
|
This is really interesting. Based on my observations, the Navigation block-related test stopped being flaky after merging this revert. IMO, there should be no behavioral change if we don't use fallback's embedded record to seed the cache; just an extra REST API request. Maybe this means we have a different issue in the Nav block code. |
getdave
added a commit
that referenced
this pull request
Feb 27, 2024
* Revert the changes that removed the feature * Fix nits Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: MaggieCabrera <onemaggie@git.wordpress.org> Co-authored-by: kevin940726 <kevin940726@git.wordpress.org>
9 tasks
I think that's highly likely. Some kind of edge case that has been masked. |
|
I just manually cherry-picked this PR to the cherry-pick-wp-6-5-beta-3 branch to get it included in the next release. |
getdave
added
Backported to WP Core
|
I just manually cherry-picked this PR to the cherry-pick-wp-6-5-beta-3 branch to get it included in the next release. |
getdave
added a commit
that referenced
this pull request
Feb 27, 2024
* Revert the changes that removed the feature * Fix nits Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: MaggieCabrera <onemaggie@git.wordpress.org> Co-authored-by: kevin940726 <kevin940726@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Reverts #59076
Fixes #48033
Why?
Now that the regression in Core has been fixed and committed this won't occur
WordPress/wordpress-develop#6133
How?
Reverts PR changes.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast