-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REST API: Fix embedded items 'context' regression #6133
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
@TimothyBJacobs @spacedmonkey would you be able to help validate the fix here. This is a regression that happened during the 6.5 cycle, therefor, it would be good to land this fix on the same release. |
This fix looks good to me as well. I'd love if we could have unit tests that are covering this specifically as part of the |
Committed in https://core.trac.wordpress.org/changeset/57659 |
What
Fixes regression introduced in #43439, where navigation embed items were missing
raw
property values.Why
The
WP_REST_Server::match_request_to_handler
mutates the$request
object and sets the defaultcontext=view
, which prevents settingcontext=embed
as it's appropriate for these requests.The unit tests missed regression since they didn't mimic the actual requests.
How
context
before matching a request to the handler.Testing instructions
npm run test:php -- --filter test_embedded_navigation_post_contains_required_fields
.Trac ticket: https://core.trac.wordpress.org/ticket/43439
This Pull Request is for code review only. Please keep all other discussions in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.