Data Views: Ignore cmd-click when row not selectable #59697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `ViewGrid`, move the check for `hasBulkAction` out of the condition and into the block of the outer `if` statement. This is done so that the event mechanics remain the same whether the row is selectable or not; in particular, the statements to event stop propagation and prevent default shouldn't be predicated on that ability.
mcsf
added
[Type] Bug
|
Size Change: +8 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
jorgefilipecosta
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Fixes the issue in my tests and the code change looks good. Thank you for this fix @mcsf!
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59563 (comment)
What?
When using cmd + click on an item that isn't selectable, simply ignore that event, thereby preventing the item's checkbox from flashing from checked to unchecked. This was already the case in the Grid view, and this pull request applies the same idea to Table view.
How?
In
ViewTable, check the value ofhasPossibleBulkActionbefore proceeding with selection changes.In
ViewGrid, move the check forhasBulkActionout of the condition and into the block of the outerifstatement. This is done so that the event mechanics remain the same whether the row is selectable or not; in particular, the statements to event stop propagation and prevent default shouldn't be predicated on that ability.Testing Instructions
See report in #59563 (comment).