-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data views: Update template actions #60075
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +8 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I regret flip-flopping over this, but I think there's nuance here! In the regular post list, I like the delete button. I think it can still exist here. It's not destructive as it moves to the trash can, it doesn't actually delete forever. My main concern was with the revert user customizations, that's currently irrevokable. Can we move just that? |
This PR is about templates where there is no trash mechanic. Once deleted the template is gone forever. I also feel we should be consistent about the placement of destructive actions.
I think this one also needs a confirmation dialog but that's separate (#60072). |
Ah, that seems fine, assuming we can keep it for posts and pages. Good call, and let's land this one. We already use the term "Move to trash" when a "trashcan" exists, but "Delete" when it doesn't, but we were using the trash icon even for delete, that was probably wrong. This PR solves that. 🚢 |
Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
What?
Follows up #59551 and implements some changes discussed in #56603:
Testing Instructions
Screenshots or screencast
For reference, here's the actions for pages: