[Mobile] - Prevent passing potential false values to the onPress prop
#60595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 9, 2024 13:08
…AddBlock and onToggle
…he media options reference directly
geriux
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.75 MB ℹ️ View Unchanged
|
geriux
changed the title
false values to the onPress propfalse values to the onPress prop
twstokes
approved these changes
Apr 11, 2024
# Conflicts: # packages/react-native-editor/CHANGELOG.md
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
4 tasks
|
@geriux for my own education, would you mind sharing how you identified these specific lines to change/guard? |
Of course! Well, I'm still waiting to see if we don't get any new reports since I couldn't reproduce it, but hopefully, this would address it. From the crash reports, the code line being referenced was the following: So I then looked through all of the code base and the usage of the My gut feeling is that there are cases where users tap several times potentially on low-end devices while UI items are being re-rendered causing the app to crash when there's an invalid value set in the My idea with this PR was to see if this could be the case, if we still get crash reports then it would have to be something unrelated to the Thanks for asking about it and let me know if you have any other questions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR aims to fix a potential crash where it appears an
onPressprop has afalsevalue.Why?
There are a few crash events on low-end devices where the editor crashes in the Pressability component of React Native. After several different investigations, we haven't found reproducible steps of this problem.
How?
This PR prevents passing optional values to the
onPressprop of theButtonBlockAppendercomponent andMediaEditbutton in the Cover block.With these changes, a function will always be passed with checks to prevent passing potential
falsevalues.Testing Instructions
Note
It's recommended to smoke test the following as there are no reproducible steps
ButtonBlockAppender - Test case 1
+button to add a blockButtonBlockAppender - Test case 2
+button to add a Columns block+appender button and add a blockButtonBlockAppender - Test case 3
+button to add a Buttons block+appender button and add another Button blockCover Block MediaEdit
+button and add a Cover blockTesting Instructions for Keyboard
N/A
Screenshots or screencast
ButtonBlockAppender
ButtonBlockAppender.mov
Cover Block MediaEdit
MediaEdit.mov