TypeError: `false` is not a function #6359

fluiddot · 2023-11-07T10:36:11Z

Symbolicated stack trace:

gutenberg/node_modules/react-native/Libraries/Pressability/Pressability.js:758:_performTransitionSideEffects
gutenberg/node_modules/react-native/Libraries/Pressability/Pressability.js:695:_receiveSignal
gutenberg/node_modules/react-native/Libraries/Pressability/Pressability.js:525:responderEventHandlers.onResponderRelease
gutenberg/node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-prod.js:22:invokeGuardedCallbackImpl
gutenberg/node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-prod.js:40:invokeGuardedCallback
gutenberg/node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-prod.js:53:invokeGuardedCallbackAndCatchFirstError
gutenberg/node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-prod.js:73:executeDispatch
gutenberg/node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-prod.js:1125:executeDispatchesAndReleaseTopLevel
gutenberg/node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-prod.js:361:forEachAccumulated
gutenberg/node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-prod.js:1160:batchedUpdates$argument_0
gutenberg/node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-prod.js:8457:batchedUpdatesImpl
gutenberg/node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-prod.js:1106:batchedUpdates
gutenberg/node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-prod.js:1137:_receiveRootNodeIDEvent
gutenberg/node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-prod.js:1209:ReactNativePrivateInterface.RCTEventEmitter.register$argument_0.receiveTouches
gutenberg/node_modules/react-native/Libraries/BatchedBridge/MessageQueue.js:427:__callFunction
gutenberg/node_modules/react-native/Libraries/BatchedBridge/MessageQueue.js:113:__guard$argument_0
gutenberg/node_modules/react-native/Libraries/BatchedBridge/MessageQueue.js:368:__guard
gutenberg/node_modules/react-native/Libraries/BatchedBridge/MessageQueue.js:112:callFunctionReturnFlushedQueue

Raw stack trace ⤵️

value@1:436892
value@1:436464
onResponderRelease@1:435281
c@1:359373
m@1:359430
v@1:359462
w@1:359594
Le@1:363833
$@1:361102
anonymous@1:364185
Ce@1:421849
Ne@1:363753
Me@1:364026
receiveTouches@1:416736
value@1:166857
anonymous@1:165357
value@1:166303
value@1:165315

The text was updated successfully, but these errors were encountered:

dcalhoun · 2023-11-08T19:45:18Z

I spent time reviewing the history and logs for this crash. Capturing a few notes for posterity.

The crash occurs for both posts and pages.
The largely occurs on low- and medium-end devices, 62% and 23% respectively.
The crash often times occurs immediately after the insertion of a block, but not always.
Some crashes occur after several editor open and close events.
Some crashes are preceded by performance warnings, e.g. Timeout reached before response from requestGetHtml, EditPostRepository: Transaction is writing on a locked thread.

dcalhoun · 2023-11-10T19:11:21Z

After spending more time debugging this, I am still unable to reproduce the error.

For next steps, I plan to implement a few more block editor analytic events to see if they help uncover any specific actions that correlate with this error. In the meantime, I will keep myself assigned to this issue as the DRI, but I do not plan to debug it further at this time.

sentry-io · 2023-11-29T19:22:26Z

Sentry issue: WORDPRESS-IOS-452F

sentry-io · 2023-11-29T19:22:58Z

Sentry issue: JETPACK-IOS-14MW

dcalhoun · 2023-12-05T18:33:52Z

From further testing, my belief is that this crash and others (#6127, #6128, #6203) may relate to performance issues. Specifically, posts with a good number of images often slow or hangs when attempting to persist the post content via the Update or Save buttons.

Before or during this period of a hanging app, one can queue up several actions by tapping various UI element — moving blocks, opening block settings, inserting blocks, etc. My belief is that these queued actions could ultimately be executed against incorrect or nonexistent blocks once the app resumes and the various logic for each interaction are finally executed.

I was able to twice reproduce a crash with a similar stack trace to #6128 with the following:

Open a post with a few text blocks and a lot of images (e.g. 3 galleries of 90+ images each).
Make a text modification to mark the post as "dirty."
Focus an image block and attempt to open the block settings.
Before the block settings opens, tap the "Update" button to save the post's content.

Once the persisting the post updates finished, the app attempted to open the block settings and threw the crash referenced in #6128. Unfortunately, while the stack trace resembles the crash, it does not include the details required (line numbers) for symbolicating the stack trace.

Crash Stack Trace

Unhandled JS Exception: TypeError: Cannot read property 'name' of null

This error is located at:
    in k
    in RCTView
    in Unknown
    in o
    in RCTView
    in Unknown
    in S
    in S
    in v
    in InspectorControlsSlot
    in Unknown
    in RCTView
    in Unknown
    in RCTView
    in Unknown
    in T
    in Unknown
    in RCTScrollContentView
    in RCTScrollView
    in O
    in ScrollView
    in h
    in Unknown
    in Unknown
    in Unknown
    in RCTView
    in Unknown
    in RCTView
    in Unknown
    in RCTView
    in Unknown
    in Unknown
    in RCTView
    in Unknown
    in A
    in Unknown
    in PanGestureHandler
    in Unknown
    in RCTView
    in Unknown
    in A
    in Unknown
    in RCTView
    in Unknown
    in T
    in Unknown
    in RCTView
    in Unknown
    in A
    in Unknown
    in u
    in u
    in Unknown
    in RCTView
    in Unknown
    in ScreenContainer
    in Unknown
    in RCTView
    in Unknown
    in Unknown
    in T
    in RCTView
    in Unknown
    in h

Xcode Screenshot

Suggested Next Steps

Profile posts with a large number of images to understand where most of the time is spent, e.g. JavaScript thread vs native threads.
Continue attempting to reproduce various crashes during app hangs by interacting with various UI elements for various block types.

dcalhoun · 2023-12-05T18:46:31Z

An update regarding the stack trace: I was able to symbolicate the stack trace after discovering the additional details are available in Xcode when clicking the "hamburger menu" icon next to the crash (captured in an image below).

Xcode Crash Details

Xcode shows additional stack trace details in the editor rather than the console log

The symbolicated stack trace is attached below as well. It appears to point to the fact that getBlock returns null (which is possible) and we attempt to access a name attribute on the null block.

Symbolicated stack trace for #6128

This error is located at:
    in k
    in RCTView
    in Unknown
    in o
    in RCTView
    in Unknown..., stack:
/workdir/gutenberg/packages/block-editor/src/components/block-styles/index.native.js:28:selector
/workdir/gutenberg/packages/data/src/components/use-select/index.js:134:registry.__unstableMarkListeningStores$argument_0
/workdir/gutenberg/packages/data/src/registry.js:123:__unstableMarkListeningStores
/workdir/gutenberg/packages/data/src/registry.js:204:<anonymous>
/workdir/gutenberg/packages/data/src/components/use-select/index.js:133:updateValue
/workdir/gutenberg/packages/data/src/components/use-select/index.js:180:<anonymous>
/workdir/gutenberg/packages/data/src/components/use-select/index.js:205:useMappingSelect
/workdir/gutenberg/packages/data/src/components/use-select/index.js:294:useSelect
/workdir/gutenberg/packages/block-editor/src/components/block-styles/index.native.js:33:BlockStyles
/workdir/gutenberg/node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-prod.js:3525:renderWithHooks
/workdir/gutenberg/node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-prod.js:4491:updateFunctionComponent
/workdir/gutenberg/node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-prod.js:7850:beginWork$1
/workdir/gutenberg/node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-prod.js:7304:performUnitOfWork
/workdir/gutenberg/node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-prod.js:7297:workLoopSync
/workdir/gutenberg/node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-prod.js:7279:renderRootSync
/workdir/gutenberg/node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-prod.js:6975:performSyncWorkOnRoot
/workdir/gutenberg/node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-prod.js:2145:flushSyncCallbacks
/workdir/gutenberg/node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-prod.js:6650:scheduleUpdateOnFiber
/workdir/gutenberg/node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-prod.js:3767:forceStoreRerender
/workdir/gutenberg/node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-prod.js:3752:subscribe$argument_0
/workdir/gutenberg/packages/data/src/components/use-select/index.js:69:onStoreChange
/workdir/gutenberg/packages/data/src/components/use-select/index.js:76:onChange
/workdir/gutenberg/packages/data/src/registry.js:247:currentSubscribe$argument_0
/workdir/gutenberg/packages/data/src/redux-store/index.js:351:store.subscribe$argument_0
/workdir/gutenberg/node_modules/redux/lib/redux.js:304:dispatch
/workdir/gutenberg/packages/data/src/redux-store/thunk-middleware.js:7:<anonymous>
/workdir/gutenberg/packages/redux-routine/src/index.js:24:<anonymous>
/workdir/gutenberg/packages/data/src/promise-middleware.js:20:<anonymous>
/workdir/gutenberg/packages/data/src/resolvers-cache-middleware.js:45:<anonymous>
/workdir/gutenberg/packages/data/src/redux-store/index.js:224:Proxy$argument_1.apply
/workdir/gutenberg/packages/core-data/src/actions.js:428:<anonymous>
/workdir/gutenberg/packages/data/src/redux-store/thunk-middleware.js:4:<anonymous>
/workdir/gutenberg/packages/redux-routine/src/index.js:24:<anonymous>
/workdir/gutenberg/packages/data/src/promise-middleware.js:20:<anonymous>
/workdir/gutenberg/packages/data/src/resolvers-cache-middleware.js:45:<anonymous>
/workdir/gutenberg/packages/data/src/redux-store/index.js:204:<anonymous>
/workdir/gutenberg/packages/editor/src/store/actions.js:139:<anonymous>
/workdir/gutenberg/packages/data/src/redux-store/thunk-middleware.js:4:<anonymous>
/workdir/gutenberg/packages/redux-routine/src/index.js:24:<anonymous>
/workdir/gutenberg/packages/data/src/promise-middleware.js:20:<anonymous>
/workdir/gutenberg/packages/data/src/resolvers-cache-middleware.js:45:<anonymous>
/workdir/gutenberg/packages/data/src/redux-store/index.js:204:<anonymous>
/workdir/gutenberg/packages/editor/src/store/actions.js:534:<anonymous>
/workdir/gutenberg/packages/data/src/redux-store/thunk-middleware.js:4:<anonymous>
/workdir/gutenberg/packages/redux-routine/src/index.js:24:<anonymous>
/workdir/gutenberg/packages/data/src/promise-middleware.js:20:<anonymous>
/workdir/gutenberg/packages/data/src/resolvers-cache-middleware.js:45:<anonymous>
anonymous"

To be clear, this finding is not a resolution to this issue. It relates more to #6128. However, all of these issues (#6127, #6128, #6203, #6359) still seem related to poor editor performance from my perspective. My thought is that a race condition exists that is exasperated by a hanging editor with low performance.

dcalhoun · 2023-12-20T18:44:15Z

Random thought: I wonder if upgrading to React Native >=0.72 will provide additional, helpful details for cryptic errors like this one.

sentry-io · 2024-01-31T10:16:31Z

Sentry issue: JETPACK-ANDROID-HRK

fluiddot · 2024-01-31T10:23:07Z

Extracted from the breadcrumbs of JETPACK-ANDROID-HRK, I noticed the following native error:

e/WordPress-EDITOR: Illegal selection index for text with length 12, selectionStart: 13, selectionEnd: 13, with UnknownHtmlSpan tags: []
e/WordPress-EDITOR: StackTrace: org.wordpress.mobile.ReactNativeAztec.IllegalSelectionIndexException: Illegal selection index for text with length 12, selectionStart: 13, selectionEnd: 13, with UnknownHtmlSpan tags: []
	at org.wordpress.mobile.ReactNativeAztec.ReactAztecManager.updateSelectionIfNeeded(ReactAztecManager.java:257)
	at org.wordpress.mobile.ReactNativeAztec.ReactAztecManager.setTextfromJS(ReactAztecManager.java:239)
	at org.wordpress.mobile.ReactNativeAztec.ReactAztecManager.setText(ReactAztecManager.java:220)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.facebook.react.uimanager.ViewManagersPropertyCache$PropSetter.updateViewProp(ViewManagersPropertyCache.java:93)
	at com.facebook.react.uimanager.ViewManagerPropertyUpdater$FallbackViewManagerSetter.setProperty(ViewManagerPropertyUpdater.java:136)
	at com.facebook.react.uimanager.ViewManagerPropertyUpdater.updateProps(ViewManagerPropertyUpdater.java:56)
	at com.facebook.react.uimanager.ViewManager.updateProperties(ViewManager.java:86)
	at com.facebook.react.uimanager.NativeViewHierarchyManager.updateProperties(NativeViewHierarchyManager.java:142)
	at com.facebook.react.uimanager.UIViewOperationQueue$UpdatePropertiesOperation.execute(UIViewOperationQueue.java:93)
	at com.facebook.react.uimanager.UIViewOperationQueue$1.run(UIViewOperationQueue.java:915)
	at com.facebook.react.uimanager.UIViewOperationQueue.flushPendingBatches(UIViewOperationQueue.java:1026)
	at com.facebook.react.uimanager.UIViewOperationQueue.access$2600(UIViewOperationQueue.java:47)
	at com.facebook.react.uimanager.UIViewOperationQueue$DispatchUIFrameCallback.doFrameGuarded(UIViewOperationQueue.java:1086)
	at com.facebook.react.uimanager.GuardedFrameCallback.doFrame(GuardedFrameCallback.java:29)
	at com.facebook.react.modules.core.ReactChoreographer$ReactChoreographerDispatcher.doFrame(ReactChoreographer.java:175)
	at com.facebook.react.modules.core.ChoreographerCompat$FrameCallback$1.doFrame(ChoreographerCompat.java:85)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1090)
	at android.view.Choreographer.doCallbacks(Choreographer.java:893)
	at android.view.Choreographer.doFrame(Choreographer.java:809)
	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1078)
	at android.os.Handler.handleCallback(Handler.java:907)
	at android.os.Handler.dispatchMessage(Handler.java:105)
	at android.os.Looper.loop(Looper.java:216)
	at android.app.ActivityThread.main(ActivityThread.java:7625)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:524)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:987)

I wonder if this might be a clue to narrow down the culprit of the crash.

sentry-io · 2024-02-07T16:31:39Z

Sentry issue: JETPACK-ANDROID-J1Z

sentry-io · 2024-02-14T06:41:03Z

Sentry Issue: WORDPRESS-ANDROID-2VAA

sentry-io · 2024-02-22T09:13:13Z

Sentry Issue: JETPACK-ANDROID-JM6

dcalhoun · 2024-04-01T12:34:28Z

Removing my assignment as I do not intend to work on this for the foreseeable future.

Our latest plan for addressing this crash was seeing if the React Native 0.73 upgrade provided additional clues for the origin of this crash.

geriux · 2024-04-30T10:33:45Z

An attempt to fix this issue was shipped in 24.7. So far there are no reported events but I'll continue to monitor the release to see if we can considered this as fixed.

fluiddot added [OS] Android [Type] Crash labels Nov 7, 2023

dcalhoun self-assigned this Nov 8, 2023

fluiddot mentioned this issue Nov 28, 2023

JavascriptException: com.facebook.react.modules.core.ExceptionsManagerModule in reportException #6416

Closed

dcalhoun mentioned this issue Nov 29, 2023

[iOS] RCTFatalException: Unhandled JS Exception: TypeError: false is not a function, js engine: hermes: Unhandled JS Exception: TypeError: false is not a function, js engine: hermes, stack: #6125

Closed

dcalhoun added the [OS] iOS label Nov 29, 2023

dcalhoun mentioned this issue Dec 8, 2023

RCTFatalException: Unhandled JS Exception: TypeError: Cannot read property 'name' of nullThis error is located at: in b...: Unhandled JS Exception: TypeError: Cannot read property 'name' of null #6128

Closed

SiobhyB mentioned this issue Jan 22, 2024

RNMobile: Avoid crashes by ensuring RichText value exists prior to toString calls WordPress/gutenberg#58088

Merged

RenanLukas mentioned this issue Feb 21, 2024

JavascriptException: TypeError: false is not a function, js engine: hermes, stack: wordpress-mobile/WordPress-Android#20230

Closed

dcalhoun removed their assignment Apr 1, 2024

geriux self-assigned this Apr 9, 2024

geriux mentioned this issue Apr 10, 2024

[Mobile] - Prevent passing potential false values to the onPress prop WordPress/gutenberg#60595

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TypeError: `false` is not a function #6359

TypeError: `false` is not a function #6359

fluiddot commented Nov 7, 2023 •

edited

Loading

dcalhoun commented Nov 8, 2023

dcalhoun commented Nov 10, 2023

sentry-io bot commented Nov 29, 2023

sentry-io bot commented Nov 29, 2023

dcalhoun commented Dec 5, 2023 •

edited

Loading

dcalhoun commented Dec 5, 2023 •

edited

Loading

dcalhoun commented Dec 20, 2023 •

edited

Loading

sentry-io bot commented Jan 31, 2024

fluiddot commented Jan 31, 2024

sentry-io bot commented Feb 7, 2024

sentry-io bot commented Feb 14, 2024

sentry-io bot commented Feb 22, 2024

dcalhoun commented Apr 1, 2024

geriux commented Apr 30, 2024

TypeError: false is not a function #6359

TypeError: false is not a function #6359

Comments

fluiddot commented Nov 7, 2023 • edited Loading

dcalhoun commented Nov 8, 2023

dcalhoun commented Nov 10, 2023

sentry-io bot commented Nov 29, 2023

sentry-io bot commented Nov 29, 2023

dcalhoun commented Dec 5, 2023 • edited Loading

Suggested Next Steps

dcalhoun commented Dec 5, 2023 • edited Loading

dcalhoun commented Dec 20, 2023 • edited Loading

sentry-io bot commented Jan 31, 2024

fluiddot commented Jan 31, 2024

sentry-io bot commented Feb 7, 2024

sentry-io bot commented Feb 14, 2024

sentry-io bot commented Feb 22, 2024

dcalhoun commented Apr 1, 2024

geriux commented Apr 30, 2024

TypeError: `false` is not a function #6359

TypeError: `false` is not a function #6359

fluiddot commented Nov 7, 2023 •

edited

Loading

dcalhoun commented Dec 5, 2023 •

edited

Loading

dcalhoun commented Dec 5, 2023 •

edited

Loading

dcalhoun commented Dec 20, 2023 •

edited

Loading