Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change advance to block for issue #4239 #6153

Merged
merged 2 commits into from
Apr 13, 2018
Merged

Conversation

abdullah1908
Copy link
Contributor

@abdullah1908 abdullah1908 commented Apr 12, 2018

Fixes #4239
Change Editor advanced settings to Editor block settings

Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gziolo gziolo merged commit b29b92d into WordPress:master Apr 13, 2018
@gziolo
Copy link
Member

gziolo commented Apr 13, 2018

@abdullah1908 thanks for fixing 💯

@gziolo gziolo added this to the 2.7 milestone Apr 13, 2018
abdullah1908 added a commit to abdullah1908/gutenberg that referenced this pull request Apr 15, 2018
@abdullah1908
Copy link
Contributor Author

Hello @gziolo ,

Please review the recent commit.

Thanks

@gziolo
Copy link
Member

gziolo commented Apr 16, 2018

I see your commit in here, but this PR is already merged so I can't merge it. I think you need to open a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants