Show the inserters only when a section is selected #61559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
changed the title
|
Size Change: +22 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
draganescu
added
[Type] Enhancement
draganescu
changed the title
draganescu
force-pushed
the
try/show-inserters-on-selection-only
branch
from
2f6623e
to
fb92f01
Compare
|
Flaky tests detected in fb92f01. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9188695026
|
Mamaduka
reviewed
May 22, 2024
Comment on lines
+27
to
+31
| // select the 1st pattern | ||
| await page | ||
| .frameLocator( 'iframe[name="editor-canvas"]' ) | ||
| .locator( 'header' ) | ||
| .click(); |
There was a problem hiding this comment.
This probably should be a separate test.
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Show the pattern in between inserters only when a pattern is selected.
Closes #61546.
Why?
To allow deselection to actually clear the layout of visual artefacts.
How?
Don't show inserters if there is no selection.
Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast
CleanShot.2024-05-10.at.16.03.26.mp4