Gallery Block: Cleanup v1 code #63285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -3.66 kB (-0.21%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
Hey 👋 I'll test this a bit today but I yeah I agree on removing it 🙌 |
|
@youknowriad is it ok if I push some changes to this branch? |
|
Yes, please go ahead. Thank you :) |
…ental features (List, and Quote)
This was referenced Jul 9, 2024
|
Flaky tests detected in d39410b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9856517392
|
geriux
approved these changes
Jul 9, 2024
|
Nice thanks for the help. |
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Jul 10, 2024
Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: geriux <geriux@git.wordpress.org>
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: geriux <geriux@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
While working on unrelated PRs, I found that the Gallery V1 code is still around and if I'm not wrong, this code is not needed anymore.
I'm certain that it's not needed in web but have a small doubt for native, although given the time passed since the release of V2, I expect that it's not needed anymore but would need confirmation. cc @geriux @fluiddot
Testing instructions
There should be no functional change and the gallery block should work just like today.