Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gutenberg] - Remove Gallery V1 and experimental flags #23411

Merged
merged 8 commits into from
Jul 12, 2024

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Jul 9, 2024

Related PRs:

To test:

  • Test adding a Gallery block to a post

Regression Notes

  1. Potential unintended areas of impact
    It affects only the editor.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing and existing automated tests for the Gallery block.

  3. What automated tests I added (or what prevented me from doing so)
    No tests were added since this is only removing the old Gallery block format and a few experimental flags.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@geriux geriux added the Gutenberg Editing and display of Gutenberg blocks. label Jul 9, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Jul 9, 2024

1 Warning
⚠️ This PR is assigned to the milestone 25.2. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jul 9, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23411-cc36e3e
Version25.1
Bundle IDcom.jetpack.alpha
Commitcc36e3e
App Center Buildjetpack-installable-builds #9335
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jul 9, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23411-cc36e3e
Version25.1
Bundle IDorg.wordpress.alpha
Commitcc36e3e
App Center BuildWPiOS - One-Offs #10288
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@geriux geriux added this to the 25.2 milestone Jul 9, 2024
@geriux geriux marked this pull request as ready for review July 9, 2024 15:48
@geriux geriux requested a review from dcalhoun July 9, 2024 15:54
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test plan succeeded for me. I noted oddities I observed in wordpress-mobile/gutenberg-mobile#6973 (review).

@geriux geriux added this pull request to the merge queue Jul 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 12, 2024
@jkmassel jkmassel added this pull request to the merge queue Jul 12, 2024
Merged via the queue into trunk with commit beb4fd6 Jul 12, 2024
24 checks passed
@jkmassel jkmassel deleted the gutenberg/remove-gallery-v1-and-experimental-flags branch July 12, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants