-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gutenberg] - Remove Gallery V1 and experimental flags #23411
Merged
jkmassel
merged 8 commits into
trunk
from
gutenberg/remove-gallery-v1-and-experimental-flags
Jul 12, 2024
Merged
[Gutenberg] - Remove Gallery V1 and experimental flags #23411
jkmassel
merged 8 commits into
trunk
from
gutenberg/remove-gallery-v1-and-experimental-flags
Jul 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
…ery block uses inner blocks
dcalhoun
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test plan succeeded for me. I noted oddities I observed in wordpress-mobile/gutenberg-mobile#6973 (review).
WordPress/Classes/Models/BlockEditorSettingElement+CoreDataProperties.swift
Show resolved
Hide resolved
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
To test:
Regression Notes
Potential unintended areas of impact
It affects only the editor.
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing and existing automated tests for the Gallery block.
What automated tests I added (or what prevented me from doing so)
No tests were added since this is only removing the old Gallery block format and a few experimental flags.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: