DataViews: Remove redundant setSelection prop #63648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
For clarity, this would set an array of items or an array of ids? |
|
An array of ids, I didn't change the type. |
|
Size Change: -17 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
Oh you're right I did change the types :P |
ellatrix
reviewed
Jul 17, 2024
| setSelectionState( newValue ); | ||
| } | ||
| if ( onChangeSelection ) { | ||
| onChangeSelection( newValue ); |
There was a problem hiding this comment.
Can't we just do something like this now:
const setSelectionWithChange = onChangeSelection || setSelectionStateThere was a problem hiding this comment.
no we can't, because sometimes you want the selection to be uncontrolled (you don't pass any selection prop) but you want to be notified about selection changes so you provide a onChangeSelection prop.
There was a problem hiding this comment.
When do we want this? Can't we always force it to be controlled if you want to be notified?
There was a problem hiding this comment.
For me, it's a good idea to support this, just like regular inputs or any raw form element in React. You can pass the value to make it controlled otherwise you can use onChange to be notified.
There was a problem hiding this comment.
Doesn't it log a warning in that case about an uncontrolled value?
There was a problem hiding this comment.
No, it logs a warning only when you switch from controlled to uncontrolled (or the opposite)
ellatrix
reviewed
Jul 17, 2024
| const [ openedFilter, setOpenedFilter ] = useState< string | null >( null ); | ||
|
|
||
| function setSelectionWithChange( value: SelectionOrUpdater ) { | ||
| const newValue = | ||
| typeof value === 'function' ? value( selection ) : value; | ||
| onChangeSelection( | ||
| data.filter( ( item ) => newValue.includes( getItemId( item ) ) ) | ||
| ); |
There was a problem hiding this comment.
Aren't we now passing the items? Previously we very extracting the ids and now we don't?
There was a problem hiding this comment.
No, it's the opposite, we're now passing "strings" while we previously were passing "items".
The extra logic here is to filter items that are in the selection but not in the data. The problem though is that this filtering doesn't really make sense when calling onChange since we're calling it from the "inside" meaning we know the ids are in the data already.
There was a problem hiding this comment.
Oh right, I actually changed it internally to IDs before, I forgot :D
ellatrix
approved these changes
Jul 17, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #63087
What?
Just removes a redundant
setSelectionprop from the DataViews component. We can do the same thing in theonChangeSelectioncallback.Testing Instructions
Check that you can select items properly in the different dataviews.