Update: Simplify some permission checks. #63812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -29 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
This PR had a weird/negative impact on the "navigate site editor" metric. Any ideas what that might be? |
Probably two additional We need to re-evaluate global style selectors and allow |
priethor
added
[Type] Code Quality
|
@youknowriad, create a follow-up to see if we can improve performance - #65177. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies some permission checks by using canUser instead of checking capabilities directly which is not as reliable (e.g: may not take into account some backend filters).
Props to @Mamaduka for the research that led to this PR.
Testing Instructions
I checked the editor still works as expected.
With an author role, I checked in the developer tools that there are no 403 HTTP errors while opening the editor.