Editor: Optimize global styles permission check #65177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Performance
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
commented
Sep 10, 2024
| const currentTheme = getCurrentTheme(); | ||
|
|
||
| return currentTheme && | ||
| canUser( 'read', 'global-styles/themes', currentTheme.stylesheet ) |
There was a problem hiding this comment.
This would match the request made by __experimentalGetCurrentThemeBaseGlobalStyles.
gutenberg/packages/core-data/src/resolvers.js
Line 648 in 537fb18
|
Size Change: +14 B (0%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
|
I re-run performance tests three times and |
youknowriad
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a follow-up to #63812 (comment).
PR updates the
useGlobalStylesBaseConfighook to use the correct REST API resource to check read permissions for the current theme's global styles.Why?
Making an
OPTIONSrequest to the/themesendpoint was expensive and incorrect. Using REST API paths is still the best way to check permissions for non-entity resources.Hopefully, this will improve "navigate site editor" metrics.
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast
Before
After
