Post Editor: Force iframe editor when zoom-out mode #64316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +23 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Thanks for the review!
I think this PR is needed anyway. Even if the meta box is not present, if a block below v2 is registered, the editor is not an iframe. So I think we should always check if we are in zoom-out mode. |
|
Just to be on the safe side, I'll wait a day or so before merging this PR. Let me know if you have any other concerns. |
Right. I would have realized that with a little more thought 😄. |
getdave
pushed a commit
that referenced
this pull request
Aug 14, 2024
Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: stokesman <presstoke@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #64259, #62943
Alternative to #64264
What?
This PR forces the iframe editor when in zoom-out mode to ensure the zoom-out functionality works properly.
Why?
Currently, the
useShouldIframehook will prevent the editor from being an iframe if all blocks are not all v3 or have meta boxes. If it is not an iframe, the new view "Desktop (50%)" and the zoom-out mode for experimental pattern inserters will not work.How?
Update the
useShouldIframehook to force the iframe editor when in zoom-out mode.Testing Instructions
Screenshots or screencast
7512eb804e7534218aaa8d66c4b0b5d6.mp4