Paste: fix blob uploading #64479
Merged
Paste: fix blob uploading #64479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +198 B (+0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
I think this approach is the right one. The blocks should be created properly from the start. Thanks for fixing that. We don't have the same issue for "file" and "audio"? |
youknowriad
approved these changes
Aug 13, 2024
|
No they don't have raw transforms. Yes, it's only an issue if someone was relying on being able to create a block with a blob as the URL and have it upload. |
|
Added an e2e test as well. |
Mamaduka
reviewed
Aug 13, 2024
Comment on lines
95
to
98
| if ( isBlobURL( attributes.url ) ) { | ||
| attributes.blob = attributes.url; | ||
| delete attributes.url; | ||
| } |
There was a problem hiding this comment.
I think this should be attributes.src instead of attributes.url.
|
@ellatrix, not sure why, but failing e2e tests seem to be related to the changes here. |
ellatrix
force-pushed
the
fix/blob-paste
branch
from
d63beb9
to
757f8e4
Compare
|
This seems to be a real failure. I've restarted tests twice before and had the same failure. Screeenshot
|
|
I ran it locally both on this branch and trunk, and both times it failed. 🤔 |
|
Also, this tests seems to be introduced just yesterday. |
This was referenced Aug 14, 2024
|
I don't seem to be able to reproduce the test failure, I tested both in |
|
It's odd that an unrelated e2e test caused the failure. I'll investigate this later and restore the proposed test case. |
|
Huh, this was just an idea that I didn't think would work, because locally that test still fails without my e2e test, and it also fails in trunk... |
|
Didn't notice auto merge was still on sorry |
artemiomorales
added
[Package] Block library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Since #63076, pasted blobs are no longer uploaded.
Why?
They should be.
How?
In the paste/raw transform, check if the URL is a blob and set the new attribute.
Alternatively, maybe we should handle this in the blocks: check if the url attribute is a blob on mount, and set it as the temporary URL. cc @youknowriad
Testing Instructions
See #60811.
Testing Instructions for Keyboard
Screenshots or screencast