Paste: fix image paste from Google Forms #64502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @xpurichan. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -12 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
fix/paste-g-forms
branch
from
1acf5f9
to
12c73b4
Compare
ellatrix
force-pushed
the
fix/paste-g-forms
branch
from
12c73b4
to
3244f52
Compare
|
I've tested this - following the steps in the issue #60811 and can confirm that this PR fixed the reported issue! Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Builds on the fix from #64479. When pasting from Google Forms, the image in pasted inline. This is happening because the raw HTML is an image wrapped an a
btag, and the image wasn't wrapped in a figure.Why?
Fixes #60811.
How?
Let's try to skip the body check and see if we get past integration failures. I don't see why we can't wrap any image that occurs outside of a p or div, in a figure element.
Testing Instructions
Create a Google form that generates a chart in the responses tab and copy that into GB.
Testing Instructions for Keyboard
Screenshots or screencast