Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aria-expanded to social link url popover trigger #64949

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from
Open

Add aria-expanded to social link url popover trigger #64949

wants to merge 5 commits into from

Commits on Aug 30, 2024

  1. Move social icons blockProps from li to button 

    By moving the blockProps for the social icon from the <li> to the <button>, we get the appropriate behavior of being able to select and create social icons with a clean keyboard behavior.
    @jeryj
    jeryj committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    c8cf43f View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary css for social icon button focus to make it consis… 

    …tent with other focus styles
    @jeryj
    jeryj committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    f49c692 View commit details
    Browse the repository at this point in the history

  3. Add aria-expanded attribute for url popover

    @jeryj
    jeryj committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    0638c3b View commit details
    Browse the repository at this point in the history

  4. Refactor to lessen chance of aria-exapnded state becoming out of sync

    @jeryj
    jeryj committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    b74d25a View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Remove unnecessary toString

    @jeryj
    jeryj committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    73ce2aa View commit details
    Browse the repository at this point in the history