Add aria-expanded to social link url popover trigger #64949
+42
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By moving the blockProps for the social icon from the <li> to the <button>, we get the appropriate behavior of being able to select and create social icons with a clean keyboard behavior.
…tent with other focus styles
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +11 B (0%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in b74d25a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10638683231
|
cbravobernal
added
Needs Accessibility Feedback
|
@jeryj the PR is pointing to another branch instead of |
afercia
reviewed
Sep 3, 2024
| <button aria-haspopup="dialog" { ...blockProps }> | ||
| <button | ||
| aria-haspopup="dialog" | ||
| aria-expanded={ isURLPopoverOpen.toString() } |
There was a problem hiding this comment.
Is it necessary to convert this to string? Just genuinely asking because it's the first time I see this pattern.
There was a problem hiding this comment.
You're right - it's not necessary! Thanks for catching!
|
@cbravobernal It was going to give me rebase errors due to #64883, so I'll just wait to merge this until I can point this to trunk. |
getdave
force-pushed
the
fix/double-arrow-social-icons
branch
from
f49c692
to
49c47e2
Compare
jeryj
force-pushed
the
fix/double-arrow-social-icons
branch
2 times, most recently
from
f49c692
to
eb95d1b
Compare
getdave
force-pushed
the
fix/double-arrow-social-icons
branch
from
8076181
to
8aeebee
Compare
jeryj
force-pushed
the
fix/double-arrow-social-icons
branch
from
8aeebee
to
411c567
Compare
jeryj
force-pushed
the
fix/double-arrow-social-icons
branch
from
411c567
to
64ca1c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds
aria-expandedsemantics to the button that opens the url popoverWhy?
a11y semantics
How?
Checks same semantics for when the popover shows so they stay inline.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast