Group: fix padding select #65857
Merged
Group: fix padding select #65857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
reviewed
Oct 3, 2024
|
|
||
| > * { | ||
| user-select: all; | ||
| } |
There was a problem hiding this comment.
What happens if a group is within a group, which rule should apply? I assume the "none" but It seems this won't work for it.
There was a problem hiding this comment.
Oh yes, I guess .group > * is stronger than .group.
There was a problem hiding this comment.
Also I guess it would be good to have a general solution, not just for groups, but it feels a bit dangerous to disable selection for all non editable content.
There was a problem hiding this comment.
yea, maybe we can start with groups. The other thing is should this be user-select: all; or user-select: reset; or something (we don't know what's inside the group, so would be good to have a way to reset to browser default.
|
Size Change: +274 B (+0.02%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
youknowriad
added
[Type] Bug
|
In the last commit I used "initial" instead of "all" to basically reset the default value. I felt it's a bit safer but let me know what you think. |
youknowriad
approved these changes
Oct 3, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
This is way better. Thank you Ella. I think we can consider merging as is. That said, I think it's still not solved entirely for nested groups. Use the following pattern: It's a stack within a group. |
2 tasks
ellatrix
force-pushed
the
fix/group-select
branch
from
5b23e05
to
8d9c00c
Compare
youknowriad
approved these changes
Oct 8, 2024
|
Ella, what's blocking this one? |
|
Nothing, only needed a review and merge :) |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes clicking on group padding for flex layout.
The cause: https://codepen.io/iseulde/pen/OJKNWOz
Why?
Clicking on the padding of a group with flex layout causes selection to be captured by a nested rich text block.
How?
Use
user-select: noneto prevent selection on group blocks.Testing Instructions
Example from below:
Testing Instructions for Keyboard
Screenshots or screencast