Safari: prevent focus capturing caused by flex display #66402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ellatrix
commented
Oct 24, 2024
packages/rich-text/src/component/event-listeners/prevent-focus-capture.js
Outdated
Show resolved
Hide resolved
mcsf
reviewed
Oct 24, 2024
packages/rich-text/src/component/event-listeners/prevent-focus-capture.js
Outdated
Show resolved
Hide resolved
packages/rich-text/src/component/event-listeners/prevent-focus-capture.js
Outdated
Show resolved
Hide resolved
packages/rich-text/src/component/event-listeners/prevent-focus-capture.js
Outdated
Show resolved
Hide resolved
|
Size Change: -162 B (-0.01%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
ellatrix
commented
Oct 24, 2024
|
|
||
| await expect | ||
| .poll( multiBlockSelectionUtils.getSelectedFlatIndices ) | ||
| .toEqual( [ 1 ] ); |
There was a problem hiding this comment.
So this is a weird failure: we're actually also expecting this test to clear selection in trunk (it even says it in the test title), but for some reason after the first click we check if one block is selected, and on check if selection is cleared after the second click. This caused the webkit test to fail, it now always clears the selection. When I tested Chrome manually, it did the same, but for some reason with Playwright it's still relying on two clicks.
I've also included Firefox now which seems to pass after these changes.
youknowriad
reviewed
Nov 11, 2024
ellatrix
force-pushed
the
fix/safari-click-bug
branch
from
9fd89e3
to
e8e864a
Compare
|
@youknowriad Yes, removed it. Seems to work well in Chrome too. |
|
It's a good general block across all block and all browsers. |
In some situations in safari, it feels like the "cursor" get stuck. See the screenshot above, I was trying to select the container and I was successful in doing so but it "looks" like the cursor in the paragraph is being rendered even though it doesn't really have the focus. Weird. (not a blocker) |
youknowriad
approved these changes
Nov 11, 2024
|
@youknowriad Yeah, that's why I added |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: mcsf <mcsf@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Following up from #65857. The browser bug demonstrated: https://codepen.io/iseulde/pen/OJKNWOz
Why?
How?
We can disable content editable when clicking a parent element to prevent it from capturing focus.
Testing Instructions
Click on the group padding in Safari (try many times). It should not move focus to rich text.
Testing Instructions for Keyboard
Screenshots or screencast