Core Data: Add the 'getEntitiesConfig' resolver #65871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
4 tasks
|
Size Change: +379 B (+0.02%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
|
This is looking good but it looks like the test failures are probably related. |
|
Love this! It solves the multiple |
This was referenced Oct 29, 2024
ellatrix
force-pushed
the
try/get-entities-config-resolver
branch
from
a8f2cc4
to
4bd2045
Compare
|
Phew, it took me a while to figure out what the problem with I also rebased this PR. |
|
Flaky tests detected in 384aac1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11587089428
|
ellatrix
approved these changes
Oct 29, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Thank you, @ellatrix! I'll resolve two remaining items on the todo list and land this PR. |
Mamaduka
commented
Oct 30, 2024
| @@ -43,79 +36,6 @@ describe( 'getMethodName', () => { | |||
| } ); | |||
| } ); | |||
|
|
|||
| describe( 'getKindEntities', () => { | |||
There was a problem hiding this comment.
The getKindEntities method hasn't existed since #39349.
|
@jorgefilipecosta, do you have any suggestions on where to restore the The |
|
@Mamaduka Why not the resolver? In the selector it would be called excessively, no? |
|
@ellatrix, the resolver only has access to the configs that are dynamically loaded. I assume that
That is precisely why I would like to avoid this if it is doable. |
|
Ah, I guess maybe adding a weak map check would work then. But we can also check with @youknowriad next week and fix it separately. |
|
Create a follow-up issue #66594. |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Supersedes #61101.
PR introduces a resolver for
getEntitiesConfigand replacesgetOrLoadEntitiesConfigwith it.Why?
Currently, if two or more components call
getEntityRecodsimultaneously for an entity with the config loaded from the server, theloadermethod can make duplicate requests. The resolvers keep track of HTTP requests in progress and avoid hitting the same endpoint multiple times.Based on the usages of
getOrLoadEntitiesConfig, it seems better to add a resolver for thegetEntitiesConfigselector.The idea is derived from explorations in #61088.
Todos
getOrLoadEntitiesConfigleftovers.registerSyncConfigs. Maybe we can call it inside the selector?Testing Instructions
CI checks should be green.
Testing Instructions for Keyboard
Same.