Site Editor: preload settings requests #66488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.81 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 5d50bac. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11523009291
|
ellatrix
force-pushed
the
add/settings-preload
branch
2 times, most recently
from
5be281b
to
fef278c
Compare
Mamaduka
approved these changes
Oct 30, 2024
ellatrix
force-pushed
the
add/settings-preload
branch
from
fef278c
to
d692645
Compare
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Mamaduka
reviewed
Nov 15, 2024
Comment on lines
+16
to
+30
| $paths[] = '/?_fields=' . implode( | ||
| ',', | ||
| // @see packages/core-data/src/entities.js | ||
| array( | ||
| 'description', | ||
| 'gmt_offset', | ||
| 'home', | ||
| 'name', | ||
| 'site_icon', | ||
| 'site_icon_url', | ||
| 'site_logo', | ||
| 'timezone_string', | ||
| 'url', | ||
| ) | ||
| ); |
There was a problem hiding this comment.
@ellatrix, should we also preload this path for the post editor?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
There's currently 3 settings requests that are not preloaded in the Site Editor (one GET and two OPTIONS). They are blocking requests (canvas loader), so we should preload them.
They are already preloaded in the Post Editor in core, so no need to add them there.
https://github.com/WordPress/wordpress-develop/blob/695476ea5e51d1c92f389ac236b138ceeaee8a99/src/wp-admin/edit-form-blocks.php#L68-L69
Missing in the site editor:
https://github.com/WordPress/wordpress-develop/blob/695476ea5e51d1c92f389ac236b138ceeaee8a99/src/wp-admin/site-editor.php#L90-L119
You'll notice that this PR only eliminates one GET and one OPTIONS request. That's because the preload cache only works for one API fetch call, and one of the instances uses a separate API fetch call instead of the store. This should be fixed at some point, separately. The same problem happens in the post editor. It's not too dissimilar to #65871, but it will require a different fix, sharing the OPTIONS state with
canUser.gutenberg/packages/core-data/src/entities.js
Lines 420 to 423 in 0466f7d
Why?
How?
These requests block loading the site editor content.
Testing Instructions
Check the network tab (search for "settings"). In trunk there's 3 requests. With this PR one.
Testing Instructions for Keyboard
Screenshots or screencast