PostTaxonomiesFlatTermSelector: Restore space between tag list and most used tags #66566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
P.S. I'm adding a backport label because this issue first appeared in WP 6.7. |
t-hamano
added
the
Backport to WP 6.7 Beta/RC
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +31 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 6d316c9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11577192798
|
mirka
approved these changes
Oct 29, 2024
packages/editor/src/components/post-taxonomies/flat-term-selector.js
Outdated
Show resolved
Hide resolved
…tor.js Co-authored-by: Lena Morita <lena@jaguchi.com>
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 29, 2024
…st used tags (#66566) * PostTaxonomiesFlatTermSelector: Restore space between tag list and most used tags * Update packages/editor/src/components/post-taxonomies/flat-term-selector.js Co-authored-by: Lena Morita <lena@jaguchi.com> --------- Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: fcee21f |
|
It looks like a couple of |
kevin940726
reviewed
Oct 31, 2024
| @@ -288,8 +292,15 @@ export function FlatTermSelector( { slug, __nextHasNoMarginBottom } ) { | |||
| singularName | |||
| ); | |||
|
|
|||
| const Wrapper = ( { children } ) => | |||
There was a problem hiding this comment.
I think this is creating a new component every time it's re-rendered. It's causing the focus to be lost after adding a new tag. Since this is a regression, let's fix this before RC 3 🙏.
|
Thanks for the quick fix! |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
…st used tags (WordPress#66566) * PostTaxonomiesFlatTermSelector: Restore space between tag list and most used tags * Update packages/editor/src/components/post-taxonomies/flat-term-selector.js Co-authored-by: Lena Morita <lena@jaguchi.com> --------- Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why?
#63491 resets the bottom margin of the
FormTokenFieldcomponent inside thePostTaxonomiesFlatTermSelectorcomponent.PostTaxonomiesFlatTermSelectorneeds space between both because most used tags may be rendered below theFormTokenField.How?
The
PostTaxonomiesFlatTermSelectorcomponent is publicly exposed and there may be developers who have not yet opted into__nextHasMarginBottom. To prevent double spacing, I restore the previous spacing (12px) via theVStackcomponent only if the__nextHasMarginBottomprop is enabled.Testing Instructions