Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Update packages for 6.7 RC 3 #7693

Closed

Conversation

kevin940726
Copy link
Member

@kevin940726 kevin940726 commented Oct 31, 2024

Syncs packages from Gutenberg ahead of RC 3. Contains the following PRs:

Trac ticket: https://core.trac.wordpress.org/ticket/62321


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

github-actions bot commented Oct 31, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props kevin940726, ramonopoly.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@ramonjd
Copy link
Member

ramonjd commented Oct 31, 2024

Fix for post taxonomy field bug here: WordPress/gutenberg#66625

Copy link
Member

@ramonjd ramonjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested using the test instructions in each Gutenberg PR.

The main ones:

✅ Space restored in tag selector from WordPress/gutenberg#66566

Screenshot 2024-10-31 at 2 58 51 pm

✅ Tag selector focus works from WordPress/gutenberg#66625

✅ Patterns request is avoided when loading site editor from WordPress/gutenberg#66621

Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The included PRs appear to be testing well for me. And a quick smoke test of the post and site editors and the site frontend isn't resulting in any issues as far as I can tell.

LGTM!

@kevin940726
Copy link
Member Author

Committed in r59330.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants