Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try a block-based magazine-style theme #54

Closed
wants to merge 5 commits into from
Closed

Conversation

kjellr
Copy link
Collaborator

@kjellr kjellr commented Sep 17, 2020

Addresses #53.

Here's a first pass at an example theme using a magazine-style layout. A few caveats:

  • The homepage is basically just a bunch of Latest Post blocks. These should be replaced with Query blocks when they're ready, and would ideally point to different categories/tags. It looked like I couldn't specify categories dynamically in the theme templates for now, so they're all just the most recent posts.
  • To make sure there are some posts to view, I bundled some test content, borrowed from the default Gutenberg block patterns. This can be loaded in by installing the theme on a fresh site, visiting the Customizer, and then hitting Publish.
  • I used @aristath's code snippet here to implement the alignments and it worked well! (👏 )
  • For some reason the editor styles aren't loading? I'll dig back into it later today — I probably made a typo somewhere. 😄
  • To get this out quickly, I just borrowed the overall font + color styles from Twenty Twenty.
  • It still needs a bit of style cleanup. 🙂

The following screenshots are of immediately after a fresh install, with the bundled test content:

Homepage Single Post Page
Screen Shot 2020-09-17 at 11 48 34 Screen Shot 2020-09-17 at 11 49 00

@kjellr kjellr added the block-based theme A theme using HTML templates label Sep 17, 2020
@kjellr kjellr requested a review from jffng September 17, 2020 15:59
@kjellr kjellr self-assigned this Sep 17, 2020
kjellr and others added 4 commits September 17, 2020 12:53
Co-authored-by: Jeff Ong <jeff.ong@automattic.com>
Fix the theme.json to generate root variables.
Refactor global styles theme.json
@carolinan
Copy link
Collaborator

Hi, is still something that you are working on and want to include in the theme experiments repo?

@kjellr
Copy link
Collaborator Author

kjellr commented Jan 28, 2021

I'm not sure. 😄

It's definitely outdated now, and I don't have plans to update it in the short term. I would suggest we close it, but I do think it's an interesting snapshot of an idea for how to execute a Magazine-style site with FSE. We don't really have another example of that in the repo at this point.

Would anyone else be interested in picking this up (or trying another magazine-style experiment from scratch)?

@kjellr
Copy link
Collaborator Author

kjellr commented Aug 19, 2021

I'm going to close this one out — it's pretty outdated at this point. 👍

@kjellr kjellr closed this Aug 19, 2021
@kjellr kjellr deleted the try/magazine-example branch August 19, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block-based theme A theme using HTML templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants