Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try a simple two-column landing page theme #56

Closed
wants to merge 5 commits into from

Conversation

kjellr
Copy link
Collaborator

@kjellr kjellr commented Oct 9, 2020

@ianstewart pointed me towards this layout on Carrd recently, and I wondered how simple it would be to make this as a block-based theme:

Screen Shot 2020-10-09 at 12 01 48 PM

Turns out... it's pretty simple. 😄 I built a similar one in under an hour, using some of the base from #54.

Screenshots

Homepage

Desktop Mobile
gutenberg test_(1440x900) mobile

Post Page

Desktop Mobile
gutenberg test__p=2524(1440x900) (2) mobile2

@kjellr kjellr added the block-based theme A theme using HTML templates label Oct 9, 2020
@kjellr kjellr requested a review from jffng October 9, 2020 16:09
@kjellr kjellr self-assigned this Oct 9, 2020
@ianstewart
Copy link

I especially like this demo because, being familiar with the Site Editor experiment, and how difficult it can be to set up home pages for a site like this with a non-block-based theme … well, it can be really hard doing that. Highlights a big future UX win for users.

Copy link
Collaborator

@jffng jffng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! I pushed a commit to update to the latest experimental-theme.json spec.

Testing on 9.2 and for some reason an alignfull class is added to the list element of the social icon, causing its width to be 100% and breaking them onto their own line on the front-end:

Screen Shot 2020-10-21 at 2 46 10 PM

@jffng
Copy link
Collaborator

jffng commented Oct 21, 2020

Oh and the theme screenshot should be updated!

@kjellr
Copy link
Collaborator Author

kjellr commented Oct 21, 2020

I just updated the font sizes so they work against Gutenberg master.

Testing on 9.2 and for some reason an alignfull class is added to the list element of the social icon, causing its width to be 100% and breaking them onto their own line on the front-end:

I'm unable to reproduce on my end. 🤔

Edit: Looks like that may be due to a 9.2 bug. We're seeing similar things in #57.

@kjellr
Copy link
Collaborator Author

kjellr commented Aug 19, 2021

I'm going to close this one out, as it's a bit outdated.

@kjellr kjellr closed this Aug 19, 2021
@kjellr kjellr deleted the try/two-col-landing-page branch August 19, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block-based theme A theme using HTML templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants