Sessions block #27
Closed
Sessions block #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we only have to reference the external global var in one place.
This includes the creation of a new PHP include file for shared functions.
Build out sessions-select.js. Also simplify modes so their values match the post type or taxonomy they correspond to. Also simplify to one attribute that holds the post/term ids, instead of a separate attribute for each type.
2 tasks
|
TIL: Draft pull requests. Nice! I'm guessing we can close this in favor of #33, so I'll go ahead and do that. Please re-open if there's a need to keep it though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A block version of the sessions shortcode.
Discussion
Design