Add Sessions and Sponsor blocks, and required shared components #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we only have to reference the external global var in one place.
This includes the creation of a new PHP include file for shared functions.
Build out sessions-select.js. Also simplify modes so their values match the post type or taxonomy they correspond to. Also simplify to one attribute that holds the post/term ids, instead of a separate attribute for each type.
Closed
…refactor to be used by speaker and organizer block as well
…not completed yet
When replacing tokens in a formatted string (which is often a translated string), it's problematic if the replacements include HTML, because then it has to be a string instead of a React element, which leads to using things like RawHTML. This adds some helper functions that handle things as arrays instead of strings so that they can be manipulated and added as child elements in React templates.
iandunn
reviewed
Mar 21, 2019
vedanshujain
added a commit
that referenced
this pull request
Mar 21, 2019
…ewly added common components. Note that this is condensation of multiple commits. Original pull request: #33 props coreymckrill, iandunn, vedjain
4 tasks
vedanshujain
added a commit
that referenced
this pull request
Mar 22, 2019
Note that this is condensation of multiple commits. Original pull request: #33 props coreymckrill, iandunn, vedjain
vedanshujain
added a commit
that referenced
this pull request
Mar 22, 2019
Note that this is condensation of multiple commits. Original pull request: #33 props coreymckrill, iandunn, vedjain
vedanshujain
added a commit
that referenced
this pull request
Mar 22, 2019
Note that this is condensation of multiple commits. Original pull request: #33 props coreymckrill, iandunn, vedjain
This component was deprecated in favor of ItemSelect and is no longer used anywhere.
iandunn
reviewed
Mar 22, 2019
public_html/wp-content/mu-plugins/blocks/assets/src/sponsors/block-controls.js
Show resolved
Hide resolved
* Account for tracks being null instead of an array if the data hasn't finished loading yet. * Use correct syntax for `arrayTokenReplace` to display session info.
vedanshujain
added a commit
that referenced
this pull request
Mar 25, 2019
Note that this is condensation of multiple commits. Original pull request: #33 props coreymckrill, iandunn, vedjain git-svn-id: https://meta.svn.wordpress.org/sites/trunk/wordcamp.org@8511 74240141-8908-4e6f-9713-ba540dce6ec7
This was referenced Mar 25, 2019
iandunn
reviewed
Mar 25, 2019
public_html/wp-content/mu-plugins/blocks/assets/src/speakers/block-content.js
Show resolved
Hide resolved
Closed
iandunn
changed the title
|
All code that hasn't been merged to |
|
( Note that we should not delete this branch until #44 is resolved, just in case that would delete the comments here that we still need to refer to in order to resolve all the remaining conversations ) |
coreymckrill
added a commit
that referenced
this pull request
Mar 26, 2019
This was referenced Apr 3, 2019
iandunn
added a commit
that referenced
this pull request
Apr 4, 2019
This doesn't have any tangible benefit, but is recommended by React's documentation. This partially reverts r8511. See #33
iandunn
added a commit
that referenced
this pull request
Apr 4, 2019
This doesn't have any tangible benefit, but is recommended by React's documentation. This partially reverts r8511. See #33 git-svn-id: https://meta.svn.wordpress.org/sites/trunk/wordcamp.org@8595 74240141-8908-4e6f-9713-ba540dce6ec7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands the work on the Speakers block to include several more blocks:
This is a combination of two previous pull requests, #27 and #31, because we realized that we needed to collaborate on the shared components, which would be easier in a single branch.